Skip to content

🎨 Palette: Improve rating UX and header accessibility#50

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette/improve-header-ux-a11y-8377836783354180144
Open

🎨 Palette: Improve rating UX and header accessibility#50
Gamepulse wants to merge 1 commit into
Devfrom
palette/improve-header-ux-a11y-8377836783354180144

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

I have implemented several micro-UX and accessibility improvements to the GameDetailHeader component:

  • Rating UX: Added a 'Clear' button next to the Personal Rating range input, allowing users to unset their rating to null.
  • Accessibility:
    • Updated the Favorite button with proper aria-label and aria-pressed attributes.
    • Added a semantic <label> for the Personal Rating range input.
    • Hidden decorative emojis (🌐, 📁, 🎮) from screen readers using aria-hidden="true".
    • Improved keyboard navigation by adding high-contrast focus rings to interactive elements.
  • I18n: Added a new clearRating translation key in both English and French.
  • Maintenance: Fixed an unrelated TypeScript build error in GameScreenshotsCarousel.tsx (unused variable) to ensure pnpm build passes.

Verified with Playwright screenshots and confirmed that all tests pass.


PR created automatically by Jules for task 8377836783354180144 started by @Gamepulse

- Add 'Clear' button to personal rating in GameDetailHeader
- Improve accessibility of Favorite button (aria-label, aria-pressed)
- Add proper label for rating range input
- Hide decorative emojis from screen readers
- Add high-contrast focus indicators
- Fix unused variable in GameScreenshotsCarousel to allow build

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant