Skip to content

🎨 Palette: Improve Personal Rating UX and Accessibility#46

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette/personal-rating-ux-16758512822683638821
Open

🎨 Palette: Improve Personal Rating UX and Accessibility#46
Gamepulse wants to merge 1 commit into
Devfrom
palette/personal-rating-ux-16758512822683638821

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

This PR implements a micro-UX improvement for the Personal Rating feature.

💡 What:

  • Added a "Clear Rating" button (✕) next to the personal rating label in the game detail header.
  • Converted the rating display into a semantic <label> associated with the range input.
  • Marked the "0" and "100" markers as aria-hidden.
  • Cleaned up an unused state variable in GameScreenshotsCarousel.tsx that was causing build failures.

🎯 Why:

  • Native HTML range inputs cannot represent a null state once interacted with. Users needed a way to remove a rating entirely.
  • Improved accessibility ensures screen readers correctly identify the rating slider and ignore decorative text.

♿ Accessibility:

  • Proper label association using htmlFor.
  • Descriptive aria-label and title for the new "Clear Rating" button.
  • Reduced noise for screen readers by hiding decorative markers.

PR created automatically by Jules for task 16758512822683638821 started by @Gamepulse

- Added a "Clear Rating" button to allow unsetting personal ratings.
- Improved accessibility by associating the rating label with the range input.
- Added `aria-hidden="true"` to decorative range bounds (0 and 100).
- Added `clearRating` translation keys for English and French.
- Removed an unused variable in `GameScreenshotsCarousel.tsx` to fix a build error.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant