Skip to content

🎨 Palette: Improve personal rating UX and accessibility#45

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-ux-improvement-13499473923930011348
Open

🎨 Palette: Improve personal rating UX and accessibility#45
Gamepulse wants to merge 1 commit into
Devfrom
palette-rating-ux-improvement-13499473923930011348

Conversation

@Gamepulse

Copy link
Copy Markdown
Owner

This PR implements several micro-UX and accessibility improvements focused on the personal rating system:

  1. Clear Rating Functionality: Added an '✕' button next to the personal rating in the game detail header. This allows users to completely unset their rating, which was previously impossible with the range slider once a value was set.
  2. Improved Rating Accessibility:
    • Updated the RatingInput component (used in other parts of the app) to include aria-pressed for the selected rating and more descriptive labels (e.g., "Rate 4 out of 10").
    • Added aria-label to the 0-100 range input in GameDetailHeader.
    • Marked decorative "0" and "100" text labels as aria-hidden="true" to reduce screen reader noise.
  3. Localization: Added English and French translations for the new "Clear Rating" button.
  4. Code Cleanup: Removed an unused hasIgdbId state from GameScreenshotsCarousel that was causing strict TypeScript build failures.

These changes make the rating system more intuitive to use and fully accessible to screen reader users.


PR created automatically by Jules for task 13499473923930011348 started by @Gamepulse

- Added "Clear Rating" button to `GameDetailHeader` to allow unsetting personal ratings.
- Added localized `clearRating` translation keys in English and French.
- Improved accessibility for `RatingInput` by adding `aria-pressed` and descriptive `aria-label`s.
- Enhanced accessibility in `GameDetailHeader` by adding `aria-label` to the range input and `aria-hidden` to static labels.
- Cleaned up unused state in `GameScreenshotsCarousel` to fix build errors.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant