Skip to content

Integerate bvmodeq final version from CAV#16

Open
limpa105 wants to merge 100 commits into
GaloisInc:mainfrom
epertseva-galois:integerate-cav-bvmodeq
Open

Integerate bvmodeq final version from CAV#16
limpa105 wants to merge 100 commits into
GaloisInc:mainfrom
epertseva-galois:integerate-cav-bvmodeq

Conversation

@limpa105

@limpa105 limpa105 commented May 4, 2026

Copy link
Copy Markdown

No description provided.

@jprider63 jprider63 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @limpa105! I left a few minor comments / suggestions.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should delete this file.

Comment thread bvmod_eq/.DS_Store

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete this file too.

unfold Vector.append
simp (config := { failIfUnchanged := false })
solveMLE 32
simp

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: This can be simplified with: simp [AND_64, evalSubtable, subtableFromMLE, Vector.append]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants