Draft: Bump Lean version to 4.28.0-rc1#12
Conversation
|
I'm able to run |
39bbc6d to
128c947
Compare
128c947 to
4ea5a19
Compare
|
I have updated the PR wrt. the changes I merged in main earlier today. I have a fix that makes BVMod type-check again. However, some of Liza's proofs are failing, and they might take a lot of time to figure out. I think we should probably merge, and only fix these proofs if we need them. |
|
Hmm if the proofs fail I would prefer to hold off on bumping Lean versions until we have time to fix them. We don't need the latest Lean version right now do we? |
Yes, that makes sense to me. Let's hold off. I'll go ahead and revert to the old version in the Jolt PR. @jprider63 Do you think it would be better to keep this MR as is in draft status, or to close it and start a new one once we want to update? Happy either way. |
|
I'd say we leave it open as a draft PR. For the Jolt PR, it's likely fine that it points to the commit on this branch since that currently builds. |
This is an attempt to bump the Lean version to take advantage of some recent performance improvements in Lean. We change the Lean version in all
lean-toolchainfiles, as well as the cslib and mathlib dependencies in the variouslakefile.tomlfiles.Note that this is built on top of #11.