Skip to content

Fix magic apiary GUI bypassing claim protection#63

Merged
Dream-Master merged 2 commits into
masterfrom
fix/magic-apiary-gui-client-side-open
May 4, 2026
Merged

Fix magic apiary GUI bypassing claim protection#63
Dream-Master merged 2 commits into
masterfrom
fix/magic-apiary-gui-client-side-open

Conversation

@Eldrinn-Elantey

@Eldrinn-Elantey Eldrinn-Elantey commented May 4, 2026

Copy link
Copy Markdown

Summary

  • BlockMagicApiary.onBlockActivated() called player.openGui() on both client and server instead of server-only, causing the client to open a phantom GUI with windowId=0
  • When claim protection mods (e.g. ServerUtilities) cancelled the server-side interaction and sent forceUpdate(inventoryContainer)`, the window-0 packets were misapplied to the phantom apiary container - causing the player's equipped armor to appear in the produce slots
  • Added !world.isRemote guard so the GUI is only opened server-side, matching standard Forge practice

@Eldrinn-Elantey Eldrinn-Elantey requested a review from a team May 4, 2026 13:15
@Dream-Master Dream-Master merged commit f88d1f8 into master May 4, 2026
1 check passed
@Dream-Master Dream-Master deleted the fix/magic-apiary-gui-client-side-open branch May 4, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants