Imply that enabling "containsMixinsAndOrCoreModOnly" will prevent late mixins from being loaded#45
Open
Charsy89 wants to merge 3 commits into
Open
Imply that enabling "containsMixinsAndOrCoreModOnly" will prevent late mixins from being loaded#45Charsy89 wants to merge 3 commits into
Charsy89 wants to merge 3 commits into
Conversation
…e mixins from being loaded
Member
|
The spirit of |
Member
Author
|
No idea if the plan is to only update the comment or correct(?) the behavior. Both paths sound equally as good. Alex left that comment and I agreed, and after that this thing kind of went dark. I could take the time to learn how this thing works and attempt a fix, but I feel much more comfortable leaving it in the hands of someone who actually has experience with Gradle workings and especially mixin wizardry, and also how GTNHGradle itself functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the comment for
containsMixinsAndOrCoreModOnlyto specify "early mixins" instead of just "mixins". The way the comment is worded had me under the impression that this included "late" mixins, and it ended up creating lots of headache...I feel like others could be tripped up by this, which is why I thought it would be a good idea to change the comment like this.
(I closed my initial PR GTNewHorizons/ExampleMod1.7.10#293 after seeing that the comment must be updated here)