734 namespaced calls - #735
Open
dragosmg wants to merge 67 commits into
Open
Conversation
All dplyr function calls are now namespace-qualified with dplyr::, so explicit importFrom directives are no longer needed. vars() is kept unqualified since internal NSE logic pattern-matches on the literal call name (see comment in R/tfrmt-package.R). Also fixes three call-as-value references that the earlier namespacing pass missed (bare symbols passed to map()/safely() rather than called directly): - safely(select) -> safely(dplyr::select) in apply_tfrmt.R - map_dbl(last) -> map_dbl(dplyr::last) in apply_page_plan.R - map(select, ...) -> map(dplyr::select, ...) in tfrmt_sigdig.R
Also fixes two call-as-value references missed by earlier regex-based
namespacing: do.call("crossing", ...) in apply_col_plan.R and
reduce(crossing) in mock_tbl.R.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…and `expr_text()` calls
…and `quo_name()`
dragosmg
marked this pull request as ready for review
July 28, 2026 11:58
alanahjonas95
previously approved these changes
Jul 29, 2026
alanahjonas95
left a comment
Collaborator
There was a problem hiding this comment.
thanks makes sense/ looks good :)
Contributor
🦺 Coverage summary🟢 Merging PR #735 ( DetailsFiles with changes in coverage
Coverage for modified lines
♻️ Comment updated with the latest results. Created on 2026-07-29 with covr2gh v0.0.0.9041. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
Config/testthat/parallel: true)TESTTHAT_CPUS=7)@exportS3 methods, even internal ones"):eval_tidyselect_on_colvec.quosure()eval_tidyselect_on_colvec.quosures()expr_to_filter.quosure()expr_to_filter.quosures():=,!!,!!!, and%||%).datapronounf_rhs()andf_rhs<-: we overloadf_rhsinsidefrmt_when()({rlang} f_rhs() and f_rhs<-: we overload f_rhs inside frmt_when() #753)vars(): a re-export of the {tidyselect}vars()which has since been deprecated ({dplyr} vars(): a re-export of the {tidyselect} vars() which has since been deprecated #752)An unrelated problematic aspect: the use of
.dataas object name. I think we should restrict this to only mean {rlang}'s.datapronoun. (#755)There are a couple of implicit agreements this PR relies on. Going forward we:
package::function()) and we only use non-namespaced calls for operators (or other relevant exceptions).@importFromdirectives in function files. All should be centralised in the package doc.fixes #734