New vision#113
Merged
Merged
Conversation
andrewtarzia
requested changes
Jul 31, 2025
andrewtarzia
left a comment
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
Great work @SimoneMartino98 - a few things to change.
Note, I did not read the css or js code - not my expertise sadly. But if you have unit tests, and it runs, we go there.
matteobecchi
left a comment
matteobecchi
left a comment
Collaborator
There was a problem hiding this comment.
Everything seems good to me!
Collaborator
|
|
andrewtarzia
requested changes
Aug 25, 2025
andrewtarzia
left a comment
andrewtarzia
left a comment
Collaborator
There was a problem hiding this comment.
@SimoneMartino98 You have done really great work with this - some final things and discussions we can have offline.
Collaborator
I mean -- he turned off half the checks.... |
andrewtarzia
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Request review: @andrewtarzia @matteobecchi
Hi all;
First things first; it still requires some improvements, but since the code lines are a lot, at least you can start to review the main parts.
This PR wants to completely revise the
dynsight visioncode by adding:Minor improvements
Issue fixed or now deprecated: