Vertical localization parameters in ETKF (L2) - #729
Merged
metdyn merged 9 commits intoAug 6, 2026
Conversation
- background: datetime: set to the middle of time window - let window_type be 3D
Contributor
Author
|
This PR needs to be merged, as infrastructure for GETKF. |
metdyn
commented
Aug 6, 2026
| horizontal_resolution = template_dict['horizontal_resolution'] | ||
|
|
||
| background_ensemble = { | ||
| 'date': template_dict['window_begin_iso'], |
Contributor
Author
There was a problem hiding this comment.
I will change this back. The time window is tricky for the ensemble part because of the time stamp on the ebkg file names themselves.
metdyn
commented
Aug 6, 2026
Comment on lines
360
to
+361
| vertical_localization_lengthscale: | ||
| default_value: 4 | ||
| default_value: 2 |
Contributor
Author
There was a problem hiding this comment.
This length scale is from the GC99 function and its final values are set in suite/config file.
'date': template_dict['window_begin_iso'],
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is to be merged to #692.
Add input parameters to set values in ETKF vertical localization:
vertical_localization_lengthscale: 11vertical_localization_unit: logP / levelsvertical_localization_frac_retained_variance: 0.95These parameter knobs have been tested on Discover.
Dependencies
Already included the background datetime PR.
Impact
Tuning parameters are useful for localEnsembleDA study