Added optional support for custom_request_handler_class to AMs#927
Open
wvdemeer wants to merge 1 commit into
Open
Added optional support for custom_request_handler_class to AMs#927wvdemeer wants to merge 1 commit into
wvdemeer wants to merge 1 commit into
Conversation
Contributor
|
I would certainly use this to host xml schema definitions that are specific to the delegate |
Member
|
Looks OK to me from eyeballing it. Users will have to be careful as I'm sure various places in the code assume that the request handler has grabbed the peer certificate, but that's up to the developer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow an AM implementation to specify a custom request_handler_class to
SecureXMLRPCServer. (By adding a static class variablecustom_request_handler_classto the class specified asdelegatein the config.)I've used this to add a non XML-RPC site and web service to the AM (both using the same client SSL authentication as the AM).
The small changes in this pull request are quite generic and don't change anything if you don't add
custom_request_handler_classto the delegate. So it might be useful to add them.