Skip to content

Added optional support for custom_request_handler_class to AMs#927

Open
wvdemeer wants to merge 1 commit into
GENI-NSF:developfrom
wvdemeer:feature-cust-req-hand-cls
Open

Added optional support for custom_request_handler_class to AMs#927
wvdemeer wants to merge 1 commit into
GENI-NSF:developfrom
wvdemeer:feature-cust-req-hand-cls

Conversation

@wvdemeer

@wvdemeer wvdemeer commented Jun 1, 2018

Copy link
Copy Markdown

These changes allow an AM implementation to specify a custom request_handler_class to SecureXMLRPCServer. (By adding a static class variable custom_request_handler_class to the class specified as delegate in the config.)

I've used this to add a non XML-RPC site and web service to the AM (both using the same client SSL authentication as the AM).

The small changes in this pull request are quite generic and don't change anything if you don't add custom_request_handler_class to the delegate. So it might be useful to add them.

@dmargery

dmargery commented Jun 1, 2018

Copy link
Copy Markdown
Contributor

I would certainly use this to host xml schema definitions that are specific to the delegate

@ahelsing

ahelsing commented Jun 1, 2018

Copy link
Copy Markdown
Member

Looks OK to me from eyeballing it. Users will have to be careful as I'm sure various places in the code assume that the request handler has grabbed the peer certificate, but that's up to the developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants