Skip to content

perf(build): isolate services-core capability profiles - #1982

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/services-core-capability-profiles-pr6
Aug 2, 2026
Merged

perf(build): isolate services-core capability profiles#1982
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/services-core-capability-profiles-pr6

Conversation

@limityan

@limityan limityan commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • gate concrete filesystem, local-storage, process-runtime, and workspace-instruction owners behind four additive bitfun-services-core capability features
  • make Core, CLI, AI subscription auth, and services integrations select only the capabilities their real imports require; no narrow path enables product-full
  • isolate Tokio, Unix libc, and Windows API capabilities at the same owner boundary, including explicit lsp -> process-runtime composition
  • split mixed integration targets and protect exact profiles, source gates, Tokio ownership, and Windows dependency feature ownership in the existing boundary checker

Architecture

Runtime ownership and public paths do not move. services-core remains the concrete reusable service owner, Core remains the compatibility/product assembly facade, and product-full explicitly composes the same behavior. This change adds no crate, provider, registry, workflow, or third-party dependency.

Dependency closure

Windows/Linux counts are unique normal-dependency packages from cargo tree --no-default-features against the PR base.

Profile Before After Reduction
bitfun-services-core Windows empty 70 22 -48 (-68.6%)
bitfun-services-core Linux empty 55 22 -33 (-60.0%)
bitfun-core Windows empty 113 89 -24 (-21.2%)
Codex adapter Windows empty 115 78 -37 (-32.2%)

The empty services-core profile now carries only Tokio rt and time; filesystem, storage, process, synchronization, Unix signal, and Windows API capabilities are selected by their owners.

Validation

  • pnpm run check:core-boundaries:test (36/36)
  • pnpm run check:core-boundaries
  • Windows and Linux cargo check --locked for services-core empty, filesystem, local-storage, process-runtime, workspace-instructions, lsp, and workspace-runtime
  • focused services-core tests for empty, storage/session, process, instruction, LSP, workspace runtime, runtime ownership, and session-git profiles
  • Core empty, capability, LSP, workspace-runtime, and product-full checks
  • individual checks for affected services-integrations features, AI subscription auth, and CLI
  • pnpm run fmt:rs
  • git diff --check

The broad workspace check was not completed locally; existing CI remains the broad merge gate. No CI or workflow configuration is changed by this PR.

Review

Independent adversarial review found and closed feature-unification gaps in LSP process ownership, Tokio/libc capabilities, Windows API feature ownership, and source-gate enforcement. The final review reported no remaining P0-P2 findings.

Gate filesystem, storage, process, and instruction owners behind additive features. Keep Tokio and platform capabilities owner-scoped and protect the narrow profiles with boundary contracts.
@limityan
limityan marked this pull request as ready for review August 2, 2026 15:14
@limityan
limityan merged commit e44faa2 into GCWing:main Aug 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant