perf(build): isolate services-core capability profiles - #1982
Merged
limityan merged 1 commit intoAug 2, 2026
Merged
Conversation
Gate filesystem, storage, process, and instruction owners behind additive features. Keep Tokio and platform capabilities owner-scoped and protect the narrow profiles with boundary contracts.
limityan
marked this pull request as ready for review
August 2, 2026 15:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-services-corecapability featuresproduct-fulllibc, and Windows API capabilities at the same owner boundary, including explicitlsp -> process-runtimecompositionArchitecture
Runtime ownership and public paths do not move.
services-coreremains the concrete reusable service owner, Core remains the compatibility/product assembly facade, and product-full explicitly composes the same behavior. This change adds no crate, provider, registry, workflow, or third-party dependency.Dependency closure
Windows/Linux counts are unique normal-dependency packages from
cargo tree --no-default-featuresagainst the PR base.bitfun-services-coreWindows emptybitfun-services-coreLinux emptybitfun-coreWindows emptyThe empty services-core profile now carries only Tokio
rtandtime; filesystem, storage, process, synchronization, Unix signal, and Windows API capabilities are selected by their owners.Validation
pnpm run check:core-boundaries:test(36/36)pnpm run check:core-boundariescargo check --lockedfor services-core empty,filesystem,local-storage,process-runtime,workspace-instructions,lsp, andworkspace-runtimepnpm run fmt:rsgit diff --checkThe broad workspace check was not completed locally; existing CI remains the broad merge gate. No CI or workflow configuration is changed by this PR.
Review
Independent adversarial review found and closed feature-unification gaps in LSP process ownership, Tokio/libc capabilities, Windows API feature ownership, and source-gate enforcement. The final review reported no remaining P0-P2 findings.