feat(runtime): unify active-turn steering across clients - #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PendingQueueowner: preserve full queued payloads during explicit drain and keep images or structured metadata queued instead of flattening them into text.Competitor alignment
1882c33827cf0ce5c948b69ab5a87ed8f6790cf8: regular TUI submission uses the normal prompt path and Core defaults delivery tosteer; App follow-up defaults to steering.2b5bdcf67547860f2e5c5a605009a70026796b2b: an ordinary user turn first attempts active-turn steering and only uses turn start/fallback when steering is not applicable./steercommand. This slice remains intentionally text-only; images, workspace references, and structured GUI metadata are preserved for regular turn submission.Architecture
AgentDialogTurnPortis the only steering boundary; the old Core compatibility bypass is removed.PendingQueueManager; no second queue or delivery state machine is introduced.Verification
Passed locally:
cargo check --workspaceworkspace-runtime,remote-workspace,ssh-remote, and--no-default-featurescargo check -p bitfun-desktopEnvironment notes:
cargo test -p bitfun-desktopwas attempted after the check passed but the machine ran out of D: drive space while compiling third-party dependencies; no test assertion or PR compiler error was reached.