fix(flow-chat): improve permission request previews - #1941
Merged
Conversation
- Add a shared `CopyableTextPreview` for interactive, multiline text tooltips with a copy action. - Reuse it for command and permission-resource previews, using the BitFun theme font and a wider tooltip. - Show batch permission actions for a single pending request, and prevent allow actions when rejection feedback is present. - Refine permission-panel visual states, including the collapse button and disabled-button cursors. - Move the text-copy hook into the shared FlowChat hooks directory and update all command-preview consumers.
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CopyableTextPreviewfor interactive, multiline text tooltips with a copy action.Fixes #
Type and Areas
Type:
UI/UX, bug fix, refactor
Areas:
Web UI, FlowChat permission requests, tool cards
Motivation / Impact
Permission resource and interactive command previews are now readable, hoverable, and copyable even for multiline content. Permission actions are more consistent for one or many requests, and rejection feedback no longer permits contradictory allow actions.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/PermissionRequestPanel.test.tsx— passed (10 tests)pnpm --dir src/web-ui run test:run src/flow_chat/components/CopyableTextPreview.test.tsx— passed (1 test)pnpm run type-check:web— passedpnpm run i18n:audit— passed with 0 warningsgit diff --cached --check— passedReviewer Notes
Checklist