Skip to content

fix(flow-chat): improve permission request previews - #1941

Merged
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:dev
Aug 1, 2026
Merged

fix(flow-chat): improve permission request previews#1941
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:dev

Conversation

@wsp1911

@wsp1911 wsp1911 commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add a shared CopyableTextPreview for interactive, multiline text tooltips with a copy action.
  • Reuse it for command and permission-resource previews, using the BitFun theme font and a wider tooltip.
  • Show batch permission actions for a single pending request, and prevent allow actions when rejection feedback is present.
  • Refine permission-panel visual states, including the collapse button and disabled-button cursors.
  • Move the text-copy hook into the shared FlowChat hooks directory and update all command-preview consumers.

Fixes #

Type and Areas

Type:

UI/UX, bug fix, refactor

Areas:

Web UI, FlowChat permission requests, tool cards

Motivation / Impact

Permission resource and interactive command previews are now readable, hoverable, and copyable even for multiline content. Permission actions are more consistent for one or many requests, and rejection feedback no longer permits contradictory allow actions.

Verification

  • pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/PermissionRequestPanel.test.tsx — passed (10 tests)
  • pnpm --dir src/web-ui run test:run src/flow_chat/components/CopyableTextPreview.test.tsx — passed (1 test)
  • pnpm run type-check:web — passed
  • pnpm run i18n:audit — passed with 0 warnings
  • git diff --cached --check — passed

Reviewer Notes

  • Manual desktop/browser verification was not run. Please verify tooltip pointer transition, copy feedback, and the disabled cursor in the permission panel.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

- Add a shared `CopyableTextPreview` for interactive, multiline text tooltips with a copy action.
- Reuse it for command and permission-resource previews, using the BitFun theme font and a wider tooltip.
- Show batch permission actions for a single pending request, and prevent allow actions when rejection feedback is present.
- Refine permission-panel visual states, including the collapse button and disabled-button cursors.
- Move the text-copy hook into the shared FlowChat hooks directory and update all command-preview consumers.
@wsp1911
wsp1911 merged commit 9685195 into GCWing:main Aug 1, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant