fix(cli): make dispatch storage locks portable - #1894
Merged
Conversation
Use the existing fs2 dependency for real cross-process locks, recover incomplete event tails with a writable handle, and defer busy retention cleanup safely on Windows. Keep detached worker support limited to Linux and macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The Windows lock helper reported success without acquiring a lock. Event logs were opened in append mode even though recovery needs truncation, retention attempted to rename a directory while its lock file was still open, and one cancellation test depended on Unix-only process behavior.
Scope
Verification
cargo test -q -p bitfun-cli(476 unit tests plus all CLI integration suites)cargo check --workspacenode scripts/check-core-boundaries.mjsnode scripts/check-repo-hygiene.mjsgit diff HEAD^ --checkrustfmt --edition 2021 --check src/apps/cli/src/dispatch/mod.rs src/apps/cli/src/dispatch/store.rs