feat(cli): support session deletion in Shared TUI - #1891
Merged
Conversation
limityan
force-pushed
the
yanzhn/shared-tui-session-delete
branch
from
July 30, 2026 10:13
3b155b7 to
4936f34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AgentRuntime::delete_sessionas the only behavior owner: Embedded calls it directly and Shared maps one private local IPC operation to the same requestoutcome_unknownrecovery instead of adding a delete task or queuemain; the combined private protocol is v7Scope and behavior
not_foundandsession_in_useremain typed failures; a timed-out side effect returnsoutcome_unknown, closes the connection, and is never retried automaticallymainRebase notes
Rebased onto
gcwing/main@29c2b1569. Both branches had independently used private protocol v6, so the combined delete + reload operation set now uses v7. Conflict resolution retained both user paths and consolidated their policy in one closed operation-rules table.Validation
cargo check --workspacecargo test -p bitfun-agent-runtime-ipc(43 passed)cargo test -p bitfun-cli shared_runtime::tests -- --nocapture(14 passed)cargo test -p bitfun-cli session_delete -- --nocapture(4 passed)rustfmt --checknode scripts/check-core-boundaries.mjspnpm run check:repo-hygienegit diff --check gcwing/main...HEADThe full Windows CLI test binary was also exercised: 469 tests passed and five existing
dispatchfile-lock/path tests failed outside this diff. Two lock-contention tests are structurally unsupported by the currentcfg(not(unix))implementation, and the remaining failures reproduce as Windowsos error 5; this PR does not modifysrc/apps/cli/src/dispatch.