Skip to content

feat(skills): support explicit invocation arguments - #1868

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/external-skill-invocation
Jul 30, 2026
Merged

feat(skills): support explicit invocation arguments#1868
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/external-skill-invocation

Conversation

@limityan

@limityan limityan commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • honor Claude-compatible user-invocable and argument-hint metadata in Web and CLI/TUI invocation surfaces while keeping user and model visibility independent
  • accept optional Skill tool arguments and expand the loaded prompt through one shared static helper reused by the existing Claude command adapter
  • align Web and CLI/TUI insertion on [$skill-name], showing argument hints without inserting them into user input

Boundaries

  • keeps direct Skill discovery and existing registry precedence/load paths; no import records, source graph, coordinator, cache, watcher, or new settings
  • does not add Plugin Runtime, hooks, MCP, customization, dynamic shell execution, named arguments, or allowed-tools/fork/agent/model semantics
  • leaves management, mode enablement, permission identity, and local/remote workspace ownership unchanged

Review fixes

  • complete the internal SkillInfo test fixture so the full agent-runtime test target compiles
  • preserve backslashes before non-placeholder dollar expressions such as \$HOME, while retaining the documented single- and double-backslash behavior for supported placeholders
  • add owner regression coverage for ordinary variables, invalid indexed placeholders, and dynamic-variable-shaped text

Validation

  • cargo check --locked --workspace
  • cargo test --locked -p bitfun-agent-runtime
  • cargo test --locked -p bitfun-services-core --features markdown --test markdown_owner_contracts
  • cargo test --locked -p bitfun-claude-code-adapter --test command_source
  • cargo test --locked -p bitfun-core skill_ --lib -- --nocapture
  • cargo test --locked -p bitfun-cli skill_selector -- --nocapture
  • cargo test --locked -p bitfun-cli -p bitfun-acp -p bitfun-agent-runtime --no-run
  • pnpm run type-check:web
  • pnpm --dir src/web-ui run test:run src/flow_chat/utils/skillPromptReference.test.ts
  • node scripts/check-core-boundaries.mjs
  • pnpm run check:repo-hygiene
  • git diff --check

A fresh independent adversarial review passed with no P0-P2 findings after the two review issues were fixed. The full Windows CLI execution additionally reached five dispatch file-lock/concurrency failures in untouched code; those failures are not counted as successful validation, while the exact combined compile step above passes.

@limityan
limityan force-pushed the yanzhn/external-skill-invocation branch from 3b4d1f1 to 43a1355 Compare July 30, 2026 02:06
@limityan
limityan marked this pull request as ready for review July 30, 2026 02:21
@limityan
limityan merged commit 2300514 into GCWing:main Jul 30, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant