feat(cli): select current session model in shared TUI - #1867
Merged
Conversation
limityan
force-pushed
the
yanzhn/shared-session-model
branch
from
July 30, 2026 02:32
4b08cc6 to
311b011
Compare
limityan
marked this pull request as ready for review
July 30, 2026 02:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/modelsto change only the current Session modelAgentSessionModelPortowner used by Embedded TUIArchitecture and behavior
UpdateSessionModeloperation; no SDK Host, public protocol, model catalog, or default-setting operation is added/modelsnow has current-Session scope in both deployments; Startup model selection remains the default for future Sessionsauto,primary, andfastremain Runtime-owned Session selectors; the local catalog resolves them only for picker highlighting and readable displayExplicitly out of scope
Validation
cargo check --workspacecargo test -p bitfun-agent-runtime-ipc(32 passed)cargo test -p bitfun-cli --test product_assembly_cli(10 passed)node scripts/check-core-boundaries.mjsnode scripts/check-repo-hygiene.mjsgit diff --checkThe five excluded Dispatch tests do not overlap the changed files; they reproduce on this Windows checkout through access-denied, process-claim, lock, and process-identity baseline behavior.
Two independent adversarial reviews covered the complete PR from architecture and product perspectives. Their persistence-consistency and stale-event findings were fixed and re-reviewed; final P0/P1/P2 counts are zero.