feat(notifications): notify background permission requests - #1819
Merged
Conversation
Add a default-enabled permission request notification preference. Notify for actionable core and ACP approval requests while BitFun is in the background, with request de-duplication and same-round batching. Keep the listener active in toolbar mode and apply preference changes immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1812
Type and Areas
Type: Feature
Areas: Rust core, desktop/Tauri, web UI, ACP, i18n
Motivation / Impact
Users can now receive a generic OS notification when an approval request needs attention while BitFun is in the background. The notification intentionally excludes tool arguments and other sensitive request details.
Verification
pnpm --dir src/web-ui run test:run src/app/hooks/permissionRequestNotifyPolicy.test.ts src/flow_chat/services/flow-chat-manager/AcpPermissionToolCardModule.test.ts(6 tests passed)pnpm run type-check:webpnpm run i18n:auditcargo check -p bitfun-desktopcargo test -p bitfun-core permission_request_notifications_default_to_enabledpnpm run fmt:rsgit diff --cached --checkReviewer Notes
sessionId + roundId; requests from separate sessions remain separate OS notification calls.desktop:build:fastexecutable.Checklist