fix(flow-chat): prevent background activity menu clipping - #1817
Merged
Conversation
- Render FlowChat background activity action menus through a fixed portal so they are not clipped by the activity panel scroll container. - Reposition open menus on resize and scroll, including nested activity-list scrolling. - Preserve outside-click behavior and add focused coverage for portal rendering and menu interaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type:
Bug fix / UI/UX
Areas:
Web UI, FlowChat
Motivation / Impact
The three-dot menu for a trailing background activity could be rendered below its trigger but clipped by the activity panel. Users can now access action menus regardless of the activity item's position in the scrollable list.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/FlowChatHeader.test.tsxpnpm run type-check:webgit diff --cached --checkReviewer Notes
The menu uses the existing fixed-popover viewport helper, which prefers below-anchor placement and flips above when needed. No user-facing strings or locale resources changed.
Checklist