Skip to content

fix(review): restore focused check details safely - #1780

Merged
limityan merged 2 commits into
GCWing:mainfrom
limityan:yanzhn/review-details-recovery
Jul 26, 2026
Merged

fix(review): restore focused check details safely#1780
limityan merged 2 commits into
GCWing:mainfrom
limityan:yanzhn/review-details-recovery

Conversation

@limityan

Copy link
Copy Markdown
Collaborator

Summary

  • open Review check cards into the real child-session detail instead of an empty shell
  • project transcript availability and execution outcome independently across timeout, stop, failure, restart, and remote-session recovery
  • keep history hydration under one FlowChat manager owner and make detail loading read-only, without rerunning the model
  • persist one runtime-admitted public label while keeping prompts, capability keys, paths, packet IDs, and other coordination fields out of UI events
  • return authoritative cancellation results from desktop and server adapters, and wait for runtime confirmation before showing a stopped state

Boundaries

  • no new Review taxonomy, scheduler, cache, telemetry subsystem, or second lifecycle owner
  • no model rerun when details are opened or reloaded
  • language auto-follow behavior is intentionally outside this PR
  • architecture and recovery behavior are documented in docs/architecture/review-lifecycle.md

Validation

Area Result
Review UI behavior 8 focused files, 171 tests passed
Frontend contracts type-check, lint, i18n audit passed
Focused assignment admission 10 Rust tests passed
Event projection 2 Rust tests passed
Review launch contract 5 Rust tests passed
Desktop session recovery 1 targeted Rust test passed
Repository boundaries core-boundary, repository-hygiene, and theme audits passed
Independent review architecture, correctness, and product reviewers reported no P0-P2 findings

Known build output is limited to existing dependency deprecation notices and the existing Windows linker warning.

@limityan
limityan force-pushed the yanzhn/review-details-recovery branch from e76ce89 to 3bc9055 Compare July 26, 2026 11:14
@limityan
limityan merged commit 2848b58 into GCWing:main Jul 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant