feat(web): add configurable pointer-follow glow - #1743
Merged
Conversation
wsp1911
added a commit
to wsp1911/BitFun
that referenced
this pull request
Jul 27, 2026
MouseGlowService measured every composed-path ancestor while resolving a glow surface, potentially forcing two synchronous layouts per element. It then measured the selected surface and ordinary stacking host again. This could enter Blink flex layout repeatedly while session content was mounting, eventually causing a WebView2 STATUS_ACCESS_VIOLATION. Detect candidates from styles and semantics, measure only the selected surface, and keep normal overlays fixed under document.body. Preserve local positioning for actual floating layers and reuse an existing rect when the floating surface is its own host. The regression originated in 1ec2213 (GCWing#1743).
3 tasks
wsp1911
added a commit
that referenced
this pull request
Jul 27, 2026
MouseGlowService measured every composed-path ancestor while resolving a glow surface, potentially forcing two synchronous layouts per element. It then measured the selected surface and ordinary stacking host again. This could enter Blink flex layout repeatedly while session content was mounting, eventually causing a WebView2 STATUS_ACCESS_VIOLATION. Detect candidates from styles and semantics, measure only the selected surface, and keep normal overlays fixed under document.body. Preserve local positioning for actual floating layers and reuse an existing rect when the floating surface is its own host. The regression originated in 1ec2213 (#1743).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: Feature / UI/UX
Areas: Web UI, settings, themes, i18n
Motivation / Impact
Provides optional pointer feedback across interface surfaces instead of limiting the effect to the settings page. The preference is persisted locally, defaults to enabled, and light-theme colors use a higher-contrast indigo treatment for visibility.
Verification
pnpm run type-check:web— passedpnpm --dir src/web-ui run test:run src/infrastructure/mouse-glow/core/MouseGlowService.test.ts— 5 tests passedpnpm run i18n:audit— passed with 0 warningspnpm run theme:color-audit:all— passedgit diff --check— passedReviewer Notes
The effect uses a single pointer-events-free overlay and requestAnimationFrame-throttled surface detection. Existing theme tokens are used; no new dependency or color literal was added.
Checklist