feat(flow-chat): surface terminal failures in chat - #1722
Merged
Conversation
- Persist terminal turn error messages and structured provider diagnostics through session history. - Render localized inline failure notices in FlowChat, including expandable technical details and raw-error copy. - Keep zero-round failed turns in the transcript and remove their notification-center error toast.
wsp1911
marked this pull request as ready for review
July 23, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #
Type and Areas
Type:
Feature / UI/UX
Areas:
Rust core, desktop/Tauri, web UI
Motivation / Impact
Terminal failures, including failures before a model round starts, now remain visible and searchable in the conversation. Users can inspect provider, HTTP, request ID, and raw diagnostics without leaving FlowChat.
The notification center no longer shows turn-failure errors. MCP interaction and ACP permission error notifications remain unchanged.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/components/modern/TurnFailureNoticeItem.test.tsx(2 passed)pnpm --dir src/web-ui run test:run src/flow_chat/services/flow-chat-manager/EventHandlerModule.test.ts(22 passed)pnpm run type-check:webpnpm run i18n:audit(passed, 0 warnings)git diff --checkcargo check --workspacedid not complete within the local 120-second timeout.Reviewer Notes
Session fields are optional and backward-compatible. Failed zero-round turns are retained instead of being restored to the pending queue and deleted.
Checklist