fix(account): harden login finalize, peer hydrate, and relay deploy - #1637
Merged
bobleer merged 2 commits intoJul 19, 2026
Conversation
Defer session persistence until sync choice is finalized, skip fail-closed cloud turn fetch in Peer Device Mode, and harden one-click relay deploy preflight/cancel/port ownership with regression docs at critical nodes.
Remove CJK from AccountLoginDialog comments, pass live workspace into createChatSession call sites, clear workspace before peer emit, align CLI pending login status, and keep relay_deploy commands controller-local.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
account_finalize_login), so killing the app on the overwrite screen no longer restores a logged-in state; closing that UI logs out.account_fetch_session_turnson the controller, soft-no-op related cloud paths, clear stale workspace paths on peer switch, pass live workspace intocreate_session, and keep config/mode HostInvokes high priority.RELAY_PORT) and add regression READMEs/comments at account login, peer-device, and relay-deploy critical nodes.Test plan
bitfun-relay; register/import works; Remote Connect Self-Hosted entry opens the wizard.pnpm run type-check:webandpnpm run i18n:auditfor UI/locale paths;cargo check -p bitfun-desktopfor Tauri/API changes.