refactor(desktop): route primary interactions through runtime - #1594
Merged
limityan merged 1 commit intoJul 17, 2026
Merged
Conversation
limityan
force-pushed
the
yanzhn/refactor-desktop-agent-runtime
branch
from
July 17, 2026 09:01
800e46e to
89113e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
raw_metadatarule.Type and Areas
Type: Refactor
Areas: Desktop/Tauri, Agent Runtime adapter boundary, architecture docs, tests
Motivation / Impact
Desktop previously called Core interaction owners directly. This change establishes the intended adapter boundary for the production interaction slice without moving runtime ownership or claiming that the complete Desktop product profile is assembled.
No direct user-facing feature change is intended. Core remains the sole owner of coordination, scheduling, sessions, tools, persistence, and the Agentic event queue. The facade only retains
Arcreferences to four already-implemented ports and creates no I/O, threads, channels, or secondary state owners.Verification
rustup run nightly cargo fmt --all -- --checkrustup run nightly cargo check -p bitfun-desktop --quietrustup run nightly cargo test -p bitfun-desktop --quiet— 107 passedrustup run nightly cargo test -p bitfun-agent-runtime --quiet— 232 unit tests plus all integration suites passedrustup run nightly cargo build -p bitfun-desktop --quietnode scripts/check-core-boundaries.mjsgit diff --check gcwing/mainThe coherent installed nightly toolchain was used because this machine's stable Cargo, rustc, and standard-library components are version-skewed. This PR does not add nightly-only code or configuration. Existing MCP deprecation warnings remain unchanged.
Reviewer Notes
DeliveryProfile::Desktop, register placeholderRuntimeServices, or claim an unavailableEventscapability. Complete Desktop product assembly is deferred until real required service providers and an event consumer/projection path exist.Checklist