refactor(acp): route server through assembled runtime - #1590
Merged
Conversation
limityan
force-pushed
the
refactor/acp-assembled-runtime
branch
from
July 17, 2026 03:30
f2c2bfc to
910156c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeliveryProfile::Acp, validated runtime services, harnesses, and the public Agent Runtime SDKProduct and architecture boundaries
CoreProductAgentRuntime::buildAPI remains compatible; ACP event injection is additive throughbuild_acpRuntime impact
No additional scheduler, persistence manager, runtime owner, background forwarding task, or protocol schema is introduced. Session-scoped channel memory exists only while a consumer is active and is released with the final receiver.
Validation
cargo +nightly test -p bitfun-agent-runtime -p bitfun-acp -p bitfun-cli(all unit, contract, doc, and integration tests passed)bitfun-cli acpstdio initialize smoke with isolated storage rootscargo +nightly test -p bitfun-core(1,101 passed, 1 ignored; the existing timing-sensitiveslow_provider_is_not_respawned_while_healthy_sibling_updatesfailed only under concurrent compile contention and passed 3/3 in isolation)cargo +nightly fmt --all -- --checknode --test scripts/check-core-boundaries.test.mjsnode scripts/check-core-boundaries.mjsgit diff --check