Skip to content

fix(web-ui): allow Tab focus traversal inside modal dialogs #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobleer merged 1 commit into from
Jul 16, 2026
Merged

fix(web-ui): allow Tab focus traversal inside modal dialogs #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/web-ui/src/main.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,14 +188,21 @@ function registerGlobalErrorHandlers() {

registerGlobalErrorHandlers();

// Disable Tab-key focus traversal globally.
// Tab still works inside Monaco Editor and xterm terminal where it has semantic meaning.
// Disable Tab-key focus traversal globally (IDE-style chrome).
// Allow Tab where it has semantic meaning: Monaco, xterm, and modal/dialog forms
// (SSH connect, account login, settings dialogs, etc. — Modal focus trap keeps focus inside).
document.addEventListener(
'keydown',
(e: KeyboardEvent) => {
if (e.key !== 'Tab') return;
const target = e.target as Element | null;
if (target?.closest('.monaco-editor, .xterm')) return;
if (
target?.closest(
'.monaco-editor, .xterm, [role="dialog"], [aria-modal="true"]'
)
) {
return;
}
e.preventDefault();
},
true
Expand Down
Loading