fix(review): require explicit follow-up delivery - #1560
Merged
Conversation
limityan
force-pushed
the
yanzhn/review-subagent-delivery
branch
from
July 15, 2026 10:43
4ffed8f to
583242d
Compare
limityan
marked this pull request as ready for review
July 15, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_in_background=trueplusallow_review_follow_up=trueProduct behavior
Scope
This change does not add natural-language review classification, generic task groups, UI changes, result deduplication, or new cancellation semantics.
allow_review_follow_uppermits later delivery but does not detach the task from normal parent cancellation.Validation
cargo +nightly test -p bitfun-core agentic::tools::implementations::task::tests --features product-full -- --nocapture(68 passed)cargo +nightly test -p bitfun-core review_follow_up --features product-full -- --nocapture(7 passed)cargo +nightly test -p bitfun-core cold_ --features product-full -- --nocapture(6 passed)cargo +nightly test -p bitfun-core agentic::agents::registry::tests --features product-full -- --nocapture(23 passed)cargo +nightly check -p bitfun-core --features product-fullnode scripts/check-core-boundaries.mjspnpm run check:repo-hygienerustfmt +nightly --check --edition 2021 ...git diff --check gcwing/main..HEADIndependent review
Independent architecture and product-design reviews found and closed issues around misleading detach semantics, cold-session restore side effects, workspace-aware reviewer identity, missing success-path coverage, user-facing recovery guidance, and duplicate transcript reads. Both final reviews report no remaining actionable findings.