Skip to content

fix(review): require explicit follow-up delivery - #1560

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-subagent-delivery
Jul 15, 2026
Merged

fix(review): require explicit follow-up delivery#1560
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-subagent-delivery

Conversation

@limityan

Copy link
Copy Markdown
Collaborator

Summary

  • make review subagents completion dependencies by default so the owning agent can return one merged review result
  • allow later review delivery only when the user explicitly requested not to wait, via run_in_background=true plus allow_review_follow_up=true
  • classify built-in and custom reviewers through the workspace-aware registry, including cold reused sessions, without changing non-review background tasks
  • fail closed before fully restoring cold review sessions, while using a zero-turn read-only preflight to avoid duplicate transcript loading

Product behavior

Scenario Behavior
ordinary review request waits for review results; parallel foreground reviewers can still run concurrently
explicit "background, do not wait" review returns now and delivers the review in a later follow-up
non-review background task unchanged
managed Review / DeepReview flows unchanged

Scope

This change does not add natural-language review classification, generic task groups, UI changes, result deduplication, or new cancellation semantics. allow_review_follow_up permits later delivery but does not detach the task from normal parent cancellation.

Validation

  • cargo +nightly test -p bitfun-core agentic::tools::implementations::task::tests --features product-full -- --nocapture (68 passed)
  • cargo +nightly test -p bitfun-core review_follow_up --features product-full -- --nocapture (7 passed)
  • cargo +nightly test -p bitfun-core cold_ --features product-full -- --nocapture (6 passed)
  • cargo +nightly test -p bitfun-core agentic::agents::registry::tests --features product-full -- --nocapture (23 passed)
  • cargo +nightly check -p bitfun-core --features product-full
  • node scripts/check-core-boundaries.mjs
  • pnpm run check:repo-hygiene
  • rustfmt +nightly --check --edition 2021 ...
  • git diff --check gcwing/main..HEAD

Independent review

Independent architecture and product-design reviews found and closed issues around misleading detach semantics, cold-session restore side effects, workspace-aware reviewer identity, missing success-path coverage, user-facing recovery guidance, and duplicate transcript reads. Both final reviews report no remaining actionable findings.

@limityan
limityan force-pushed the yanzhn/review-subagent-delivery branch from 4ffed8f to 583242d Compare July 15, 2026 10:43
@limityan
limityan marked this pull request as ready for review July 15, 2026 10:43
@limityan
limityan merged commit 642cfcf into GCWing:main Jul 15, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant