fix(review): improve large-target review flow - #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/is entered at the start of an input that already has trailing textBehavior change
launch_batchis documented as a preferred capacity grouping, while the runtime guarantee remains the global concurrency ceiling. This avoids introducing a second scheduler or workflow FSM.Safety and scope
GetFileDiff,Read,Grep,Glob, andLSIndependent review
Independent senior architecture and product-design reviews were run against the full change. Their findings were fixed and re-reviewed:
launch_batchcontract without adding a schedulerLaunchReviewAgentinto the existing Review coverage cardBoth final reviews reported no remaining P0-P2 findings and no boundary expansion.
Validation
pnpm --dir src/web-ui run test:run ...— 12 files, 187 tests passedpnpm run type-check:webpnpm run i18n:contract:testpnpm run i18n:audit— 0 warningspnpm run check:repo-hygienepnpm run check:github-configrustup run nightly cargo check --workspacebitfun-agent-runtime,bitfun-core, andbitfun-services-integrations --features review-platformtestsgit diff --checkThe workspace check retains pre-existing Windows
unsafe_op_in_unsafe_fnwarnings outside this change.AI-assisted implementation; all listed checks were run locally.