fix(glob): handle absolute patterns across search backends - #1546
Merged
Conversation
wsp1911
marked this pull request as ready for review
July 14, 2026 07:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rg/ walk fallback chain, while preserving Flashgrep for canonical paths inside the workspace.Type and Areas
Type:
Bug fix / regression fix
Areas:
Rust core, tool execution, workspace search
Motivation / Impact
An absolute pattern such as
C:/.../terminal-transcripts/session/*.logwas previously passed directly torg --globwhile searching from the workspace, so existing transcript files were reported as missing.Local absolute patterns now search from their static parent directory. Remote absolute patterns remain constrained to the active remote workspace, and remote shell results report the correct
matches_relative_tobase for downstream tools.Verification
pnpm run fmt:rscargo test -p tool-runtime extract_glob_base_directory_preserves_absolute_roots -- --nocapturecargo test -p bitfun-core glob_tool -- --nocapture— 13 passedcargo check --workspace— passed; existing Windows unsafe-operation warnings remain in desktop/WebDriver codegit diff --checkReviewer Notes
rg, then the internal walk fallback whenrgis unavailable or fails in the supported fallback cases.Checklist