Skip to content

feat(review): add portable subject composition contracts - #1518

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-planner-foundation
Jul 12, 2026
Merged

feat(review): add portable subject composition contracts#1518
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/review-planner-foundation

Conversation

@limityan

@limityan limityan commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds a small portable contract for composing review subjects without introducing a separate model-planning phase.

  • Represents Issue, pull request, Git range, workspace, explicit-file, and external-reference candidates with stable candidate identity.
  • Produces only subject relationships (mode and role); review questions, output shape, tool choice, and execution strategy remain owned by the main review model.
  • Uses deterministic composition only for explicit, low-ambiguity intent: single subject, explicit comparison, and explicit requirement-trace language.
  • Leaves ambiguous mixed-subject requests as multi-subject input so the main model can decide the relationship in context.
  • Preserves every candidate exactly once and applies small public-boundary limits before allocation or text scanning.

Deliberate exclusions

  • No additional model call, prompt, repair call, retry, or Agent-loop behavior.
  • No desktop command or Web API.
  • No launch, evidence collection, persistence, review execution, or UI-status changes.
  • No model-owned question or output constraints.
  • No DeepReview changes.

Validation

  • cargo test -p bitfun-product-domains --features product-full --test review_policy -- --nocapture (12 passed)
  • cargo test -p bitfun-product-domains --no-default-features -- --nocapture (passed)
  • cargo check -p bitfun-product-domains --features product-full (passed)
  • cargo check --workspace (passed; existing repository warnings only)
  • git diff --check upstream/main...HEAD (passed)

node scripts/check-core-boundaries.mjs still reports the existing review-platform optional dependency ownership baseline for sha2 and windows; this PR does not touch that integration feature or Cargo manifest.

Review focus

Please verify that deterministic inference remains limited to explicit user intent, ambiguous scenarios remain model-owned, and the public contract bounds do not narrow supported review target types.

@limityan
limityan force-pushed the yanzhn/review-planner-foundation branch from f08a527 to 10f0ded Compare July 12, 2026 16:05
@limityan limityan changed the title feat(review): add hardened model-assisted planner feat(review): add portable subject composition contracts Jul 12, 2026
@limityan
limityan marked this pull request as ready for review July 12, 2026 16:05
@limityan
limityan merged commit 342ffde into GCWing:main Jul 12, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant