Skip to content

fix(ssh-remote): fallback SSH config parsing and fill-form UX - #1405

Merged
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:fix/ssh-config-parse-fallback-and-fill-form
Jul 3, 2026
Merged

fix(ssh-remote): fallback SSH config parsing and fill-form UX#1405
bobleer merged 1 commit into
GCWing:mainfrom
bobleer:fix/ssh-config-parse-fallback-and-fill-form

Conversation

@bobleer

@bobleer bobleer commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add manual ~/.ssh/config parsing fallback when the ssh_config crate fails (e.g. Include/Match directives before the first Host block), while still using pattern-matched query() results when parsing succeeds.
  • Change SSH config host entries in the connection dialog to fill the manual form instead of connecting immediately, giving users a chance to review/edit credentials before connecting.

Test plan

  • Verify ~/.ssh/config with Include/Match before first Host still lists hosts and resolves lookup correctly
  • Verify wildcard Host * settings are applied when ssh_config parsing succeeds
  • Click a config host entry and confirm the form is populated (host, port, user, key path)
  • Connect via the filled form with both private key and password auth
  • Confirm saved-connection credential prompt still works for missing stored secrets

Add manual ~/.ssh/config parsing when ssh_config crate fails on Include/Match
directives, and change config host entries to fill the connection form instead
of connecting immediately.
@bobleer
bobleer merged commit bf04033 into GCWing:main Jul 3, 2026
4 checks passed
@bobleer
bobleer deleted the fix/ssh-config-parse-fallback-and-fill-form branch July 14, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant