refactor(theme): retire legacy Rust theme schema - #1403
Merged
Conversation
limityan
force-pushed
the
yanzhn/theme-config-legacy-cleanup
branch
from
July 3, 2026 09:08
f325f2e to
2c5954a
Compare
Remove the legacy top-level GUI theme config provider while preserving theme.id as a thin fallback to themes.current. Tighten theme color governance baselines after low-risk web and installer preset near-color merges.
limityan
force-pushed
the
yanzhn/theme-config-legacy-cleanup
branch
from
July 3, 2026 09:42
2c5954a to
0e92660
Compare
limityan
marked this pull request as ready for review
July 3, 2026 10:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
themeconfig schema/provider/default export, keeping only a thintheme.id->themes.currentfallback for old config loads/imports and old call pathsconfig.theme.iddo not lose their selected theme before deserializationColor governance impact
Compatibility and risk notes
themepayloads are normalized on load/import/save by moving onlytheme.idintothemes.current; other old GUI theme fields are intentionally no longer a public extension contract.darkandlightlegacy IDs normalize tobitfun-darkandbitfun-light; existing non-emptythemes.currentis not overridden.request.configDataenvelope and forwards rawconfigJSON to the config manager beforeGlobalConfigdeserialization.terminal.themeremains a terminal ANSI/defaults config field and is not treated as the GUI theme contract.Verification
git diff --checkpnpm run theme:color-audit:allpnpm run theme:color-audit:testpnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run -- startupThemeBootstrap.test.ts themePresetOutput.test.tspnpm --dir src/web-ui run test:runpnpm --dir BitFun-Installer run type-checkcargo test -p bitfun-core legacy_theme -- --nocapturecargo test -p bitfun-core generated_theme_prompt -- --nocapturecargo check -p bitfun-desktopcargo check --workspacecargo check/cargo teststill report existing warnings inbitfun-services-integrationsandbitfun-desktop; this PR does not introduce new Rust warnings in the touched config code.