refactor: compress language identity color palette - #1398
Merged
limityan merged 1 commit intoJul 3, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-color-contract-followup
branch
from
July 3, 2026 03:42
aadea2f to
3fcf58e
Compare
limityan
force-pushed
the
yanzhn/theme-color-contract-followup
branch
from
July 3, 2026 03:58
3fcf58e to
0ab1ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
languageIdentityAccentsfrom per-language/file colors into an 8-slot category palette.theme-token-optimization.mdwith the new audit snapshot and consumer contracts.Impact and Risk
string/numbernow share a literal blue. After product-design review, lightpunctuationremains distinct from comments and darktag/propertyremain distinct to preserve 12px code preview and JSX/HTML adjacent-token readability.BUILTIN_LANGUAGE_ACCENTSremains 48 keys,CODE_SNIPPET_LANGUAGE_ACCENTSremains 10 keys, and Prism light/dark scheme keys remain 9 each.Review Follow-up
Metrics
Verification
pnpm run theme:color-audit:allpnpm run theme:color-audit:testpnpm run type-check:webpnpm run lint:webpnpm --dir src/web-ui run test:run src/shared/context-system/core/types/CodeSnippetContextImpl.test.tspnpm --dir src/web-ui run test:rungit diff --check