refactor: compress cross-surface theme tokens - #1371
Merged
limityan merged 1 commit intoJul 1, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-cross-surface-compression
branch
from
July 1, 2026 04:42
18811bc to
9490d50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/architecture/theme-token-optimization.md.Impact
#ffffor the image-remove control over black overlay), 0 fallback/unresolved/non-contract keys.theme:color-audit:allfor implementation PRs touching theme/runtime surfaces.Verification
pnpm run theme:color-audit:testpnpm run theme:color-audit:allpnpm run theme:visual-contractpnpm run lint:webpnpm run type-check:webpnpm --dir src/web-ui run test:runpnpm run type-check:mobile-webpnpm run build:mobile-web(passes with existing Vite chunk-size warning)pnpm --dir BitFun-Installer run type-checkpnpm --dir BitFun-Installer exec vite buildcargo check --manifest-path BitFun-Installer/src-tauri/Cargo.tomlgit diff --check gcwing/main...HEADRisk Notes
#fffis intentionally retained for the image remove button because existing theme foreground tokens are not safe over a black thumbnail overlay in both light and dark themes.cssVarDefinitions.nonContractCssPrivateUnique: 0so private CSS var drift is guarded like web-ui and installer.