refactor(theme): tighten runtime token contracts - #1368
Merged
limityan merged 1 commit intoJul 1, 2026
Conversation
limityan
marked this pull request as ready for review
July 1, 2026 03:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Impact and Risk
--color-purple-300,--shadow-2xl,--motion-lazy,--easing-bounce, or--font-size-5xl.Metrics
Base data is from
gcwing/mainat70f234135e18cc63c6fed1603d8193c15c82e0ae; after data is this PR headd87f8b8bc16b19c01a754b99981ffaf0e2256843, both measured withscripts/audit-theme-colors.mjs --json --no-baseline.Review Notes
Object.entries(...)families for accent, purple, effects, motion, or typography.--radius-*and--spacing-*are retired from shared root/runtime contracts and internal reads; they remain recognized only as generated-widget iframe compatibility aliases mapped to--size-radius-*and--size-gap-*.Validation
git fetch gcwing maingit merge-base --is-ancestor gcwing/main HEADandgit rev-list --left-right --count gcwing/main...HEAD->0 1pnpm run theme:color-audit -- --top 40node --test scripts/audit-theme-colors.test.mjs-> 26 passedpnpm --dir src/web-ui run test:run src/infrastructure/theme/core/ThemeService.test.ts src/infrastructure/font-preference/types/fontPreference.test.ts src/infrastructure/theme/presets/themePresetOutput.test.ts-> 3 files / 29 tests passedpnpm run generate-startup-theme-bootstrap -- --checkpnpm run theme:visual-contractgit diff --check gcwing/main..HEADgh pr checks 1368 --repo GCWing/BitFun-> Frontend Build and Rust Build Check on macOS, Ubuntu, and Windows passed