Skip to content

refactor: move LSP service owners out of core - #1367

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/core-owner-closure
Jul 1, 2026
Merged

refactor: move LSP service owners out of core#1367
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/core-owner-closure

Conversation

@limityan

@limityan limityan commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move provider CLI credential discovery/resolution into bitfun-ai-adapters behind the cli-credentials feature, with bitfun-core keeping compatibility re-exports.
  • Move reusable LSP registry, package loading, protocol, process, project detection, config watch, and debounce owners into bitfun-services-core; keep bitfun-core as the product workspace/global bridge.
  • Make services-core LSP dependencies explicit through the lsp feature so credential and integration consumers can depend on services-core without pulling LSP-only notify/zip paths.

Compatibility and Risk

  • Existing core import paths remain available through facade/re-export modules.
  • bitfun-core explicitly enables bitfun-services-core/lsp; bitfun-ai-adapters and bitfun-services-integrations use services-core with default features disabled.
  • Services-core LSP modules stay platform-agnostic and do not depend on app, Tauri, or core product runtime modules.

Verification

  • cargo check -p bitfun-services-core --no-default-features
  • cargo test -p bitfun-services-core --features lsp lsp::
  • cargo check -p bitfun-ai-adapters
  • cargo test -p bitfun-ai-adapters --features cli-credentials cli_credentials
  • cargo check -p bitfun-services-integrations --features product-full
  • cargo check -p bitfun-core --no-default-features
  • cargo check -p bitfun-core --features product-full
  • cargo check -p bitfun-desktop
  • cargo tree -p bitfun-ai-adapters --features cli-credentials --depth 2
  • node scripts/check-core-boundaries.mjs
  • node scripts/check-core-boundaries.test.mjs
  • pnpm run check:repo-hygiene
  • cargo metadata --no-deps --format-version 1
  • git diff --check gcwing/main

@limityan
limityan force-pushed the yanzhn/core-owner-closure branch from 819ba86 to a1c3d6a Compare July 1, 2026 02:56
@limityan
limityan merged commit 75e916d into GCWing:main Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant