refactor: move LSP service owners out of core - #1367
Merged
Conversation
limityan
force-pushed
the
yanzhn/core-owner-closure
branch
from
July 1, 2026 02:56
819ba86 to
a1c3d6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bitfun-ai-adaptersbehind thecli-credentialsfeature, withbitfun-corekeeping compatibility re-exports.bitfun-services-core; keepbitfun-coreas the product workspace/global bridge.lspfeature so credential and integration consumers can depend on services-core without pulling LSP-onlynotify/zippaths.Compatibility and Risk
bitfun-coreexplicitly enablesbitfun-services-core/lsp;bitfun-ai-adaptersandbitfun-services-integrationsuse services-core with default features disabled.Verification
cargo check -p bitfun-services-core --no-default-featurescargo test -p bitfun-services-core --features lsp lsp::cargo check -p bitfun-ai-adapterscargo test -p bitfun-ai-adapters --features cli-credentials cli_credentialscargo check -p bitfun-services-integrations --features product-fullcargo check -p bitfun-core --no-default-featurescargo check -p bitfun-core --features product-fullcargo check -p bitfun-desktopcargo tree -p bitfun-ai-adapters --features cli-credentials --depth 2node scripts/check-core-boundaries.mjsnode scripts/check-core-boundaries.test.mjspnpm run check:repo-hygienecargo metadata --no-deps --format-version 1git diff --check gcwing/main