refactor(theme): consolidate domain color stops - #1362
Merged
limityan merged 2 commits intoJun 30, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-domain-consolidation
branch
from
June 30, 2026 11:41
474e921 to
dea882a
Compare
limityan
force-pushed
the
yanzhn/theme-domain-consolidation
branch
from
June 30, 2026 12:15
dea882a to
2d35b2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--color-overlay-white-03from static root exports, runtime injection, and internal product reads in favor of canonical--color-overlay-white-04; keeps an iframe-only alias fallback for historical generated widget content.Cardsubtle variant visually below the default variant with atransparentruntime mapping and adds a regression test.Audit impact
Risk review
--color-overlay-white-03was already visually equal to the 0.04 stop, so internal migration to--color-overlay-white-04has no visual delta; it remains registered only as generated widget iframe fallback compatibility, which explains the +1 compatibility alias contract.var()reads, runtime setProperty reads, or required compatibility alias role; SCSS tokens/mixins remain so current compiled component styles are unchanged.radius/spacingcompatibility aliases are deliberately retained because they are dynamic/compatibility boundaries rather than safe dead keys.--card-bg-subtledistinct from--card-bg-defaultwithout adding another color literal.Verification
git rev-list --left-right --count gcwing/main...HEAD->0 2after fetching latest upstream main.git diff --check gcwing/main...HEADpnpm run theme:color-auditpnpm run theme:color-audit:testpnpm run generate-startup-theme-bootstrap -- --checkpnpm run theme:visual-contractpnpm run lint:webpnpm run type-check:webpnpm --dir src/web-ui run test:run-> 223 files / 1280 tests passedpnpm run build:webpnpm run type-check:mobile-webpnpm run build:mobile-web