Skip to content

refactor: move tool bridge contracts to runtime owners - #1353

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/core-pr-c-execution-owner
Jun 30, 2026
Merged

refactor: move tool bridge contracts to runtime owners#1353
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/core-pr-c-execution-owner

Conversation

@limityan

@limityan limityan commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move MCP dynamic tool bridge naming, descriptor, validation, presentation, dynamic metadata, and ToolResult shaping into bitfun-agent-tools.
  • Keep MCP transport, protocol result-content rendering, and connection lifecycle in services-integrations; keep core as the Tool trait adapter and connection caller.
  • Move ACP external-agent tool naming, schema, validation, presentation, and ToolResult shaping into bitfun-agent-tools while keeping ACP config, client lifecycle, permissions, and protocol behavior in bitfun-acp.
  • Update boundary guards and local module guidance so this PR does not introduce premature extension descriptor/provider APIs.

Validation

  • pnpm run fmt:rs
  • cargo test -p bitfun-runtime-ports
  • cargo test -p bitfun-agent-tools
  • cargo test -p bitfun-acp --lib
  • cargo test -p bitfun-services-integrations --features mcp --test mcp_contracts mcp_dynamic_tool
  • node scripts/check-core-boundaries.mjs
  • node --test scripts/check-core-boundaries.test.mjs
  • pnpm run check:repo-hygiene
  • cargo check -p bitfun-core --no-default-features
  • cargo check -p bitfun-core --features product-full
  • cargo metadata --no-deps --format-version 1
  • cargo check --workspace
  • git diff --check

Note: Rust checks report existing rmcp deprecated enable_roots / enable_sampling warnings in services-integrations.

@limityan
limityan force-pushed the yanzhn/core-pr-c-execution-owner branch from d1fed48 to 88a500a Compare June 30, 2026 03:46
@limityan limityan changed the title refactor: move MCP tool bridge contracts to execution refactor: move tool and extension bridge contracts Jun 30, 2026
@limityan
limityan force-pushed the yanzhn/core-pr-c-execution-owner branch 2 times, most recently from 5bad690 to 3b12d29 Compare June 30, 2026 06:35
Move MCP and ACP external tool bridge contracts into portable execution/runtime contract owners.

Add extension capability, UI contribution, and provider mapping DTOs while keeping ACP protocol lifecycle in bitfun-acp.
@limityan
limityan force-pushed the yanzhn/core-pr-c-execution-owner branch from 3b12d29 to 6ecc685 Compare June 30, 2026 07:25
@limityan limityan changed the title refactor: move tool and extension bridge contracts refactor: move tool bridge contracts to runtime owners Jun 30, 2026
@limityan
limityan merged commit d6b7839 into GCWing:main Jun 30, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant