fix(mcp): route large tool output through shared storage policy - #1347
Merged
Conversation
Remove the MCP adapter's 12k pre-truncation so oversized MCP tool results can be handled by the shared tool-result storage policy instead. Add coverage to ensure MCP rendering preserves output beyond the old limit before storage budgeting runs.
wsp1911
marked this pull request as ready for review
June 29, 2026 11:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the MCP adapter's 12k pre-truncation so large MCP tool outputs flow into the shared tool-result storage policy. Add regression coverage to ensure MCP rendering preserves output beyond the old limit before storage budgeting runs.
Fixes #
Type and Areas
Type:
bug fix, test
Areas:
Rust core, MCP tools
Motivation / Impact
MCP tool results were truncated before the shared oversized tool-result storage path could evaluate them, which could discard content instead of persisting large outputs with a preview. MCP results now use the same downstream storage policy as other large tool outputs.
Verification
cargo test -p bitfun-core mcp_tool_result_rendering_does_not_pretruncate_before_storage_policy -- --nocapture- passedReviewer Notes
This keeps the existing shared storage thresholds unchanged; it only removes the MCP-specific 12k pre-truncation.
Checklist