refactor(web-ui): reduce theme color literal duplication - #1345
Merged
limityan merged 1 commit intoJun 29, 2026
Conversation
limityan
force-pushed
the
yanzhn/theme-color-count-reduction
branch
from
June 29, 2026 10:26
6abb3c4 to
ec85e22
Compare
Collaborator
Author
|
Independent architecture re-review update:
No code fix was required from this re-review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1197
Summary
Impact
Risk Controls
Validation
pnpm --dir src/web-ui run test:runnode --test scripts/audit-theme-colors.test.mjspnpm run theme:color-audit:testpnpm run theme:color-audit -- --top 12pnpm run theme:color-audit -- --top 20pnpm run theme:visual-contractpnpm run lint:webpnpm run type-check:webpnpm run build:webgit diff --check