Skip to content

fix(flow-chat): resolve assistant mode from session workspace - #1303

Merged
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:main
Jun 24, 2026
Merged

fix(flow-chat): resolve assistant mode from session workspace#1303
wsp1911 merged 1 commit into
GCWing:mainfrom
wsp1911:main

Conversation

@wsp1911

@wsp1911 wsp1911 commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fix the AssistantScene mode regression where entering Assistant could temporarily treat the active project session as an assistant session and switch its mode to Claw.

Fixes #

Type and Areas

Type:

bug fix / regression fix / test

Areas:

web UI, flow chat

Motivation / Impact

ChatInput previously inferred assistant mode from the global current workspace. During the AssistantScene transition, the current workspace could switch to the assistant workspace before the input target session changed, which caused a normal project session to be misclassified and written back as Claw.

This change resolves assistant-mode detection from the target session's own workspace scope instead of the transient global workspace state, and adds regression coverage for the workspace-transition case.

Verification

  • pnpm --dir src/web-ui run test:run src/flow_chat/utils/chatInputMode.test.ts
  • pnpm run type-check:web

Reviewer Notes

The fix is intentionally scoped to ChatInput mode resolution. It does not change AssistantScene entry flow; it corrects the source of truth used when deciding whether the current input target should be pinned to assistant mode.

Checklist

  • This PR is focused and does not include secrets, temporary prompts, generated scratch files, or unrelated artifacts.
  • Relevant verification is recorded above, or skipped checks are explained.
  • User-facing strings, docs, and locales are updated where applicable.

@wsp1911
wsp1911 marked this pull request as ready for review June 24, 2026 12:55
@wsp1911
wsp1911 merged commit aea4828 into GCWing:main Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant