fix(flow-chat): resolve assistant mode from session workspace - #1303
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the AssistantScene mode regression where entering Assistant could temporarily treat the active project session as an assistant session and switch its mode to
Claw.Fixes #
Type and Areas
Type:
bug fix / regression fix / test
Areas:
web UI, flow chat
Motivation / Impact
ChatInputpreviously inferred assistant mode from the global current workspace. During the AssistantScene transition, the current workspace could switch to the assistant workspace before the input target session changed, which caused a normal project session to be misclassified and written back asClaw.This change resolves assistant-mode detection from the target session's own workspace scope instead of the transient global workspace state, and adds regression coverage for the workspace-transition case.
Verification
pnpm --dir src/web-ui run test:run src/flow_chat/utils/chatInputMode.test.tspnpm run type-check:webReviewer Notes
The fix is intentionally scoped to
ChatInputmode resolution. It does not change AssistantScene entry flow; it corrects the source of truth used when deciding whether the current input target should be pinned to assistant mode.Checklist