Skip to content

refactor(core): migrate Remote Connect bot support owners - #1256

Merged
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-core-residual-owner-migration
Jun 18, 2026
Merged

refactor(core): migrate Remote Connect bot support owners#1256
limityan merged 1 commit into
GCWing:mainfrom
limityan:yanzhn/refactor-core-residual-owner-migration

Conversation

@limityan

@limityan limityan commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Move provider-neutral Remote Connect IM bot support into bitfun-services-integrations: bot config/persistence/form-state, file auto-push helpers, locale/menu rendering, chat state/interaction DTOs, and command parsing.
  • Keep the core IM bot command router and Telegram/Feishu/Weixin adapters as compatibility/concrete adapter paths because they still depend on coordinator, session manager, image context, and platform I/O.
  • Tighten the moved services API so bot implementation modules stay private and only stable root re-exports are exposed; remove unused helper/API surface left by the migration.
  • Add services-side focused tests for the moved command/state/menu owners, keep core command-router compatibility tests, and update the core decomposition plan/completed archive.
  • Fix the tool pipeline test import so boundary checks use tool_context_runtime::ToolUseContext directly.

Risk and compatibility

  • No intentional user-facing behavior, command grammar, persistence schema, menu rendering, or platform adapter behavior change.
  • Existing core paths remain available through compatibility re-exports.
  • remote-connect now enables the existing optional dirs dependency because bot persistence is owned by services-integrations; dependency checks confirm it does not pull in reqwest, rmcp, git2, russh, or terminal implementation crates.
  • Remaining IM bot router/platform adapter migration is intentionally deferred until concrete session/runtime/image/platform I/O dependencies have explicit ports.

Refs #970

Validation

  • pnpm run check:repo-hygiene
  • cargo metadata --no-deps --format-version 1
  • git diff --check gcwing/main...HEAD
  • node --test scripts/check-core-boundaries.test.mjs
  • node scripts/check-core-boundaries.mjs
  • cargo tree -p bitfun-services-integrations --no-default-features --features remote-connect -e features | Select-String -Pattern "dirs|reqwest|rmcp|git2|russh|terminal-core"
  • cargo test -p bitfun-services-integrations --features remote-connect --lib remote_connect::bot::
  • cargo test -p bitfun-core --features product-full remote_connect::bot::command_router
  • cargo check -p bitfun-services-integrations --no-default-features --features remote-connect
  • cargo check -p bitfun-services-integrations --no-default-features
  • cargo check -p bitfun-core --features product-full
  • cargo check -p bitfun-core --no-default-features

@limityan
limityan force-pushed the yanzhn/refactor-core-residual-owner-migration branch from 66a6cfb to 54ecd8a Compare June 18, 2026 03:22
@limityan
limityan merged commit ff5dcb8 into GCWing:main Jun 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant