Fix multi-repo team worker spawn#1047
Merged
Merged
Conversation
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Greptile SummaryThis PR fixes host multi-repository team-worker provisioning and cleanup.
Confidence Score: 5/5The PR appears safe to merge. No blocking failures remain. Important Files Changed
Sequence DiagramsequenceDiagram
participant TM as TeamManager
participant Git as createWorktreeSet
participant SM as SessionManager
participant Store as SessionStore
TM->>TM: Read each goal component HEAD
TM->>Git: Create worker component worktrees
Git-->>TM: Container, paths, branch ownership
TM->>SM: createSession with repoWorktrees
SM->>Store: Persist initial cleanup metadata
alt Session creation succeeds
SM-->>TM: Worker session
else Provisioning or session creation fails
TM->>Git: Clean created worktrees and owned branches
Git->>Git: Remove empty nested container
end
Reviews (2): Last reviewed commit: "test post-spawn multi-repo cleanup owner..." | Re-trigger Greptile |
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
| result.worktrees.map(worktree => worktree.worktreePath), | ||
| ); | ||
| } catch (err) { | ||
| console.error(`[team-manager] Failed to remove worker branch container ${result.container}:`, err); |
| console.error(`[team-manager] Component "${worktree.repo}" cleanup left worktree at ${worktree.worktreePath}`); | ||
| } catch { /* removed */ } | ||
| } catch (err) { | ||
| console.error(`[team-manager] Failed to clean up component "${worktree.repo}" worktree ${worktree.worktreePath}:`, err); |
| result.worktrees.map(worktree => worktree.worktreePath), | ||
| ); | ||
| } catch (err) { | ||
| console.error(`[team-manager] Failed to remove worker branch container ${result.container}:`, err); |
| result.worktrees.map(worktree => worktree.worktreePath), | ||
| ); | ||
| } catch (err) { | ||
| console.error(`[team-manager] Failed to remove worker branch container ${result.container}:`, err); |
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
🤖 Generated with Bobbit