Fix inline HTML preview theming by SuuBro · Pull Request #1042 · G-Research/bobbit

SuuBro · 2026-07-22T22:33:12Z

Summary

inject the shared live theme bridge into completed and streaming inline HTML previews without the side-panel swipe bridge
preserve authored HTML semantics with parser-backed early injection, idempotent fail-open behavior, and host-token preview chrome
cover write/edit, streaming transitions, light/dark palette changes, real Vite development loading, and clean packaged runtime loading
document inline, embedded-panel, and standalone snapshot theme contracts

Verification

build, type-check, unit, browser, E2E, regression, quality, security, and QA workflow checks passed
focused source-Vite and packed-tarball browser smokes passed

🤖 Generated with Bobbit

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

…-a58ba482

greptile-apps · 2026-07-22T22:40:52Z

Greptile Summary

This PR wires the shared PREVIEW_THEME_BRIDGE script into inline HTML previews (both the completed srcdoc declarative binding and the streaming document.write path) via a new prepareInlineHtml utility, and replaces hardcoded dark-theme chrome colors with CSS custom properties.

prepare-inline-html.ts uses DOMParser for safe, tag-shape-agnostic injection of the canonical bridge as the first <head> element; idempotency is verified by content-matching the marked script so authored collisions don't block re-injection; all parser/serializer failures are fail-open.
preview-bridge-scripts.ts gains install-state tracking in window[installKey] (disconnects stale observers across document.open() rewrites) and wraps sync() in a try/catch for transient cross-origin access failures.
Six new test files land in tests2/ covering VM runtime semantics, DOM lifecycle, and real-browser (source Vite + packaged tarball) E2E smoke paths.

Confidence Score: 5/5

Safe to merge — the change adds a well-guarded preparation layer and observer lifecycle management with no regressions on existing paths.

The new prepareInlineHtml utility is fully fail-open and the test suite covers duplicate installation, hostile authored syntax, streaming transitions, document.open() observer cleanup, and both source-Vite and packaged tarball runtimes.

No files require special attention.

Important Files Changed

Filename	Overview
src/ui/tools/renderers/prepare-inline-html.ts	New module using DOMParser to inject PREVIEW_THEME_BRIDGE as the first head element, with content-verified idempotency detection and fail-open semantics.
src/shared/preview-bridge-scripts.ts	Bridge now tracks install state in window[installKey], disconnects stale observers on document.open() rewrites, and wraps sync() in a try/catch for transient cross-origin failures.
src/ui/tools/renderers/HtmlRenderer.ts	Threads prepared HTML through both the completed srcdoc binding and the streaming document.write path; replaces hardcoded chrome colors with CSS custom properties and color-mix().
tests2/core/preview-theme-bridge-runtime.test.ts	VM-based unit tests cover observer deduplication, token/palette/font mirroring, live host mutations, and all fail-open seams.
tests2/dom/inline-html-renderer-lifecycle.test.ts	Comprehensive DOM lifecycle coverage: hostile authored syntax, preparation idempotency, streaming debounce and completion, chrome theming, and WriteRenderer/EditRenderer delegation.
tests2/browser/fixtures/inline-html-theme-source.spec.ts	Playwright fixture spec validating parse-time and live token resolution, streaming transitions, EditRenderer delegation, and absence of swipe forwarding.
tests2/browser/e2e/packaged-inline-html-theme.spec.ts	E2E tarball-consumer smoke verifying theme bridge presence and live token resolution in the packaged UI bundle.
tests2/browser/e2e/source-vite-inline-html-theme.spec.ts	E2E spec validating parse-time theme capture and live token sync against a Vite dev-server path with an isolated mock gateway.

_{Reviews (3): Last reviewed commit: "Merge remote-tracking branch 'origin/mas..." | Re-trigger Greptile}

+import { PREVIEW_THEME_BRIDGE } from "../../src/shared/preview-bridge-scripts.js";
+
+function bridgeProgram(): string {
+	const match = PREVIEW_THEME_BRIDGE.match(/^<script(?:\s[^>]*)?>([\s\S]*)<\/script>$/i);


+	return swipeMessages.slice();
+}
+
+window.addEventListener("message", (event) => {


+	const headers = { Authorization: `Bearer ${token}`, "Content-Type": "application/json" };
+	const projectResponse = await fetch(`${baseUrl}/api/projects`, {
+		method: "POST",
+		headers,


+	if (!project.id) throw new Error("packed project creation returned no id");
+	const sessionResponse = await fetch(`${baseUrl}/api/sessions`, {
+		method: "POST",
+		headers,


+			ws.close();
+			reject(new Error(`packaged session prompt timed out; messages=${JSON.stringify(messages.slice(-12))}`));
+		}, 30_000);
+		ws.on("open", () => ws.send(JSON.stringify({ type: "auth", token })));


+			const token = await readToken(join(tempRoot, "secrets"));
+			const preferenceResponse = await fetch(`${gatewayBaseUrl}/api/preferences`, {
+				method: "PUT",
+				headers: { Authorization: `Bearer ${token}`, "Content-Type": "application/json" },


Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

…-a58ba482

SuuBro · 2026-07-23T07:33:34Z

Addressed the Greptile P2 in commit 0fb13d4.

Added module-scoped bounded LRU memoization shared across inline cards (rather than a single-value instance cache, since HtmlRenderer is shared).
Reuses a lazily parsed, realm-neutral canonical bridge descriptor.
Bounds entry count and retained input/output size; oversized and fail-open results are not cached.
Added deterministic parser-count, changed-input, eviction, size-limit, oversized, and fail-open recovery coverage.

Focused DOM/reproducer/type-check tests and the full implementation workflow pass.

SuuBro · 2026-07-23T07:39:17Z

@greptileai

SuuBro and others added 23 commits July 22, 2026 21:25

test inline HTML theme bridge injection

e3b6cb5

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge inline theme reproducer

2a367a0

Fix inline HTML theme inheritance

01615e1

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge inline HTML theme bridge

0951291

test packaged inline HTML theme runtime

df807e1

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge inline theme implementation

092cf05

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

test inline HTML renderer lifecycle

6d60904

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge inline theme lifecycle tests

65e997e

test inline HTML source theme journey

513341a

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge inline theme browser journey

239cc9c

fix packaged HTML smoke fixture

9c65e6b

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge packaged inline theme smoke

7c7b33d

test: register inline HTML theme coverage

318805b

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Register inline theme tests

412b0f0

fix: validate inline theme bridge marker

165237c

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Fix inline bridge marker collision

c654dbe

test inline theme through Vite source runtime

4f47912

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Merge latest inline theme implementation

b41c2d6

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

stabilize isolated source Vite smoke

8163a08

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Add source Vite inline theme smoke

9efdd76

Document inline HTML theme bridge

ed12870

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Document inline HTML theme bridge

11aafc1

Merge remote-tracking branch 'origin/master' into goal/fix-inline-htm…

b2cb459

…-a58ba482

greptile-apps Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread src/ui/tools/renderers/prepare-inline-html.ts Outdated

github-advanced-security AI found potential problems Jul 23, 2026

View reviewed changes

SuuBro and others added 3 commits July 23, 2026 07:42

Memoize inline HTML preparation

0fb13d4

Co-authored-by: bobbit-ai <bobbit@bobbit.ai>

Memoize inline HTML preparation

6219e27

Merge remote-tracking branch 'origin/master' into goal/fix-inline-htm…

644ca96

…-a58ba482

greptile-apps Bot approved these changes Jul 23, 2026

View reviewed changes

SuuBro merged commit b3d406a into master Jul 23, 2026
6 checks passed

SuuBro deleted the goal/fix-inline-htm-a58ba482 branch July 23, 2026 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix inline HTML preview theming#1042

Fix inline HTML preview theming#1042
SuuBro merged 26 commits into
masterfrom
goal/fix-inline-htm-a58ba482

SuuBro commented Jul 22, 2026

Uh oh!

greptile-apps Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

Uh oh!

SuuBro commented Jul 23, 2026

Uh oh!

SuuBro commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

SuuBro commented Jul 22, 2026

Summary

Verification

Uh oh!

greptile-apps Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

SuuBro commented Jul 23, 2026

Uh oh!

SuuBro commented Jul 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

greptile-apps Bot commented Jul 22, 2026 •

edited

Loading