Add PR gate workflow (build, type-check, unit)#1038
Merged
Conversation
Greptile SummaryThis PR adds a GitHub Actions gate for pull requests and pushes to
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (4): Last reviewed commit: "Add PR gate workflow (build, type-check,..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| run: npm run check | ||
|
|
||
| - name: Unit gate | ||
| # vitest.config.ts pins FIXED_UNIT_WORKERS = 3; VITEST_MAX_WORKERS can |
There was a problem hiding this comment.
test:unit runs the POSIX FIFO test in tests2/core/file-mentions-resolve.test.ts, which calls execFileSync("mkfifo", ...) after the tier-1 child-process guard is installed. On ubuntu-latest, the guard throws on every attempt, so this new workflow always finishes red instead of providing a usable PR signal.
Context Used: AGENTS.md (source)
dev-milos
force-pushed
the
ci/add-pr-gate
branch
3 times, most recently
from
July 22, 2026 09:30
ec87bca to
19c1b6a
Compare
dev-milos
marked this pull request as draft
July 22, 2026 09:36
dev-milos
force-pushed
the
ci/add-pr-gate
branch
3 times, most recently
from
July 23, 2026 07:29
c0cdad7 to
88c4c69
Compare
SuuBro
approved these changes
Jul 23, 2026
First CI gate for the repo. Runs on every PR to master:
npm ci -> build -> check -> test:unit.
Scope is the fast tier only. Deliberately excluded:
- test:browser: budgeted at 3600 s wall, and playwright-v2.config.ts
reserves workers from scripts/testing-v2/ledger.mjs, which exists to
share one 24-core dev box between concurrent agent sessions. On a
single-tenant runner that machinery is inert and misleading.
- test:e2e: needs Docker and real worktrees.
Both need to be made runner-shaped before they belong in a PR gate.
Verified from a clean detached worktree at origin/master (macOS, 24 core):
npm ci 14s, build 12s, check 30s, test:unit 78s.
That run also surfaced three pre-existing unit-gate failures (14 files /
56 tests), which is the reason this gate is worth having:
1. macOS TMPDIR symlink (6 files). os.tmpdir() is /var/folders/... but
its realpath is /private/var/folders/... Tests such as
tests2/integration/project-ui-api.test.ts:55 compare a server-
canonicalized path against the raw one by strict equality. Linux has
no such indirection, so these pass in CI and fail only on macOS.
2. Node below engines (7 files). engines.node is >=22.19.0; native .ts
loading arrived in 22.18. On 22.17 the extension-host suites die with
'Unknown file extension ".ts"'. npm ci already warns EBADENGINE --
the warning is load-bearing, not cosmetic. This workflow pins 22.19.0.
3. A genuinely broken test (1 file). tests2/core/file-mentions-
resolve.test.ts:698 calls execFileSync("mkfifo"), which this repo's
own tier-1 spawn guard blocks. Introduced by G-Research#1030 and merged red
because nothing ran it.
(1) and (2) are laptop-specific and disappear on a Linux runner. (3) is
real and will make this gate red on arrival. That is intended: it is
fixed separately so this PR stays reviewable on its own, and the gate
should stay non-required until it has been observed on a few PRs.
dev-milos
force-pushed
the
ci/add-pr-gate
branch
from
July 23, 2026 11:29
88c4c69 to
0ec621c
Compare
dev-milos
marked this pull request as ready for review
July 23, 2026 11:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first CI gate:
npm ci→build→check→test:uniton every PR tomaster. Nothing currently builds or runs this code before merge.Validated on Linux (Node 22.19.0)
Excluded
test:browser— 3600s wall budget, and its Playwright config reserves workers fromscripts/testing-v2/ledger.mjs, which exists to share one dev box between concurrent sessions and is inert on a runner.test:e2e— needs Docker and real worktrees.The one failure
tests2/core/file-mentions-resolve.test.ts:698callsexecFileSync("mkfifo", ...), which this repo's own tier-1 spawn guard blocks. Introduced by #1030 and merged red because nothing ran it. Fixed separately so this PR stays reviewable on its own.A clean macOS checkout fails 14 files, but 13 are local-environment artifacts (
TMPDIRsymlink resolution, and Node below theenginesfloor of 22.19 where native.tsloading landed). All 13 pass on Linux.Rollout
Keep non-required until it has been observed on a few PRs.