1433 extract feature UI module#1441
Merged
Futsch1 merged 6 commits intoMay 24, 2026
Merged
Conversation
Futsch1
reviewed
May 23, 2026
Owner
|
@ThomasKiljanczykDev I have some comments/questions to be resolved before merging |
ThomasKiljanczykDev
force-pushed
the
1433-extract-feature-ui-module
branch
from
a95f073 to
0f0b201
Compare
# Conflicts: # app/src/androidTest/java/com/futsch1/medtimer/NotificationTest.kt # app/src/androidTest/java/com/futsch1/medtimer/ReminderTest.kt # app/src/main/java/com/futsch1/medtimer/MedTimerAppIntro.kt # app/src/main/res/drawable/alarm.xml # app/src/main/res/drawable/check2_all.xml # app/src/main/res/drawable/ic_monochrome.xml # app/src/main/res/layout/preference_widget_material_switch.xml # core/ui/src/main/res/drawable/alarm.xml # core/ui/src/main/res/drawable/check2_all.xml # core/ui/src/main/res/drawable/ic_monochrome.xml # core/ui/src/main/res/layout/preference_widget_material_switch.xml # feature/ui/src/main/res/drawable/alarm.xml # feature/ui/src/main/res/drawable/check2_all.xml # feature/ui/src/main/res/drawable/ic_monochrome.xml # feature/ui/src/main/res/layout/preference_widget_material_switch.xml
Move all strings, plurals, arrays, colors, dimens, styles/themes, drawables and mipmaps (incl. all locale variants) from :app, :feature:reminders and :feature:ui into :core:ui, and re-qualify the corresponding R references to com.futsch1.medtimer.core.ui.R. Code-coupled resources (layouts, menus, the navigation graph, preference/widget XML) stay in their feature modules.
Replace fully-qualified com.futsch1.medtimer.core.ui.R access with a plain R import in files that don't also use their own module's R. Files that reference both their own R (R.id/R.layout, kept in feature modules) and core.ui.R keep the fully-qualified core.ui.R, since only one R can be imported as plain R.
ThomasKiljanczykDev
force-pushed
the
1433-extract-feature-ui-module
branch
from
0f0b201 to
3e99791
Compare
Contributor
Author
|
@Futsch1 I've addressed your comments |
Closed
Contributor
Author
|
@Futsch1 all green. Do you have any more comments I need to address? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Futsch1 final PR, merge after the PR #1440