Bump SonarQube plugin version and use new ApplicationExtension from A…#1435
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
| private val medicineDao: MedicineDao | ||
| ) : MedicineRepository { | ||
| override suspend fun get(medicineId: Int): Medicine? { | ||
| override suspend operator fun get(medicineId: Int): Medicine? { |
Contributor
There was a problem hiding this comment.
@Futsch1 I don't think using the operator for get in repositories is a good idea.
This particular get is not a retrieval from a materialized collection as the operator get is normally used for.
Here each operator get executes a query and returns a freshly-loaded instance which is the opposite of the idiomatic use of operator get.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…GP 9.0