Feature/tikhonov inverse vc#74
Open
alasdairross wants to merge 13 commits into
Open
Conversation
…e into streamlining
…e into streamlining
alasdairross
force-pushed
the
feature/tikhonov_inverse_vc
branch
from
9f9c609 to
c1bc887
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds in the option to use Tikhonov regularisation in the matrix inversion for calculating virtual circuits. By default the Moore-Penrose is used as previously, and there is an optional argument to provide an array or diagonal matrix to define the Lambda regularisation terms (see https://en.wikipedia.org/wiki/Ridge_regression for example)
The main update is in the VirtualcCircuitHandlng in virtual_circuits.py where the new matrix inversion is done.
The following methods now have an optional
tikhonov_lambdaargumentNote this update in this PR has been added after development of the FPDT #64