Rewrite biliint as a numba-compilable function#45
Merged
Conversation
timothy-nunn
force-pushed
the
numba-biliint
branch
from
99873e2 to
24a5cf5
Compare
timothy-nunn
force-pushed
the
numba-biliint
branch
from
767e8dd to
24a5cf5
Compare
Collaborator
|
Again, looks good - thanks Tim. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites the
biliintfunction in a form that can benumbaJIT compiled.Numba does not support indexing an array with another array. Therefore, the calculation of
qq,xx,yyhad to be re-written as afor-loop.For an example non-linear freegsnke run, ~8.3% of the entire runtime was spent in the
biliint, now it is 3.7%.